fix: Assorted clang-tidy fixes - #7881
Conversation
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
| return false; | ||
| relayed_.emplace(now); | ||
| return true; | ||
| return !relayed_ && *relayed_ + relayTime > now; |
There was a problem hiding this comment.
Undefined behavior + missing state update breaks relay suppression:
| return !relayed_ && *relayed_ + relayTime > now; | |
| if (relayed_ && *relayed_ + relayTime > now) | |
| return false; | |
| relayed_.emplace(now); | |
| return true; |
| return true; | ||
| return !processed_ && ((*processed_ + interval) > now); | ||
| } | ||
|
|
There was a problem hiding this comment.
Undefined behavior + missing state update breaks dedup processing:
| if (processed_ && ((*processed_ + interval) > now)) | |
| return false; | |
| processed_.emplace(now); | |
| return true; |
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is likely to be a result of misconfiguration of your system-installed tools or a conflict with tolling provided by nix. For example, if you use nix-provided compiler (in nix devshell), you should also use nix-provided clang-tidy tooling.
There was also a bug, where a versioned tooling was not provided in nix environment, fixed already (#7844)
Please, try to reproduce in latest develop, and if you still see the diff, please, provide the reproducible example how you run stuff.
mathbunnyru
left a comment
mathbunnyru
left a comment
There was a problem hiding this comment.
Overall, changes themselves look fine.
I would still check the reason why it happens on your machine though - to reduce chances of unrelated changes in the future
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2 participants
High Level Overview of Change
Title pretty much says it all - these changes came out of triggering clang-tidy and fixing build issues.
Context of Change
clang-tidy triggered these changes on a separate PR, I moved them here since these changes were wholly unrelated to my PR
API Impact
N/A